yamt commented on a change in pull request #1558:
URL: https://github.com/apache/incubator-nuttx/pull/1558#discussion_r468386227
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -31,6 +31,10 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += -O2 -fno-strict-aliasing
endif
+ifeq ($(CONFIG_STACK_CANARIES),y)
+ ARCHOPTIMIZATION += -fstack-protector-all
+endif
Review comment:
what's the intended scope of this change?
ARCHOPTIMIZATION seems a bit too ambitious as it would affect CELFFLAGS,
CMODULEFLAGS, and even HOSTCFLAGS.
##########
File path: libs/libc/stdlib/lib_stackchk.c
##########
@@ -0,0 +1,60 @@
+/****************************************************************************
+ * libs/libc/stdlib/lib_stackchk.c
Review comment:
i guess these symbols need to be in nuttx-names.in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
