davids5 commented on a change in pull request #1558:
URL: https://github.com/apache/incubator-nuttx/pull/1558#discussion_r468490414
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -31,6 +31,10 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += -O2 -fno-strict-aliasing
endif
+ifeq ($(CONFIG_STACK_CANARIES),y)
+ ARCHOPTIMIZATION += -fstack-protector-all
+endif
Review comment:
@xiaoxiang781216
Just an FYI with armv7-m/arm_stackcheck.c the code size blows up and
performance drops considerably, there is also a reserved register that needs
initialization. What are the effect of SSP in these terms? Do you have any
metrics?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
