jlaitine commented on code in PR #16939:
URL: https://github.com/apache/nuttx/pull/16939#discussion_r2310661843
##########
sched/signal/sig_dispatch.c:
##########
@@ -755,12 +755,12 @@ int nxsig_dispatch(pid_t pid, FAR siginfo_t *info, bool
thread)
{
if (thread)
{
- /* Before the notification, we should validate the tid and
- * and make sure that the notified thread is in same process
- * with the current thread.
+ /* Before the notification, we should validate the tid. If the
+ * signal is to be delivered to a thread which has exited, it is
+ * just dropped.
*/
- if (stcb != NULL && group == this_task()->group)
+ if (stcb != NULL)
Review Comment:
IMHO, thread can't move from one group to another... This part of the code
just looks very messy, I changed it to make more sense.
More tests are welcome :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
