xiaoxiang781216 commented on code in PR #16939:
URL: https://github.com/apache/nuttx/pull/16939#discussion_r2311765528


##########
sched/signal/sig_dispatch.c:
##########
@@ -725,70 +725,31 @@ int nxsig_tcbdispatch(FAR struct tcb_s *stcb, siginfo_t 
*info,
 int nxsig_dispatch(pid_t pid, FAR siginfo_t *info, bool thread)
 {
 #ifdef HAVE_GROUP_MEMBERS
-  FAR struct tcb_s *stcb;
-  FAR struct task_group_s *group;
-
-  /* Get the TCB associated with the pid */
-
-  stcb = nxsched_get_tcb(pid);
-  if (stcb != NULL)
+  if (thread)

Review Comment:
   let's change to:
   ```
   #ifdef HAVE_GROUP_MEMBERS
     if (!thread)
       {
       }
     else
   #endif
       {
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to