linguini1 commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3246170702
> Thanks @linguini1 :-) > > * Is this possible to auto-generate this file contents based on git logs? I mean by hand with some script in `nuttx/tools/` for instance that later can be used to update the file? For now it seems to be generated by hand? Yes, I plan to use the git logs/git blame to do that. However, it will definitely need to be pruned by hand after the initial population of this file, and then maintained manually afterwards. A script will not really do a good job of understanding nuances. For instance, it was mentioned that Greg Nutt would be made a code owner of many files if this was generated by a script, although he definitely wouldn't want to be requested as a reviewer on every single PR. > * How would this work? Do you have some diagram / description? If the solution is ready we may add this to our documentation? I don't have a diagram. The way I envision this working is basically an assignment of contributors to files that they are experts on. For instance, many initial board ports (or entire board ports) and one-off drivers are written primarily by single contributors. This file will allow them to record that so they are requested for reviews when that file is changed. It will also make it a little easier to track who should be asked questions about the source code. One example is the RPi 4B board. I assigned myself the entire `bcm2711` directory since I wrote all of that code. Now, if a contributor wants to improve the I2C driver or add support for something new there, I will get requested to review their PR. This makes it more likely that I'll catch mistakes or maybe be able to suggest they use some of the API functions I wrote to simplify their code. > * How this file helps in PR processing in terms of auto-assigning the review request? The way I understand it from the GitHub documentation is that any time a PR is opened that touches one of the files in the CODEOWNERS file, the person(s) assigned to that file is automatically requested as a reviewer for the PR. > * Yes it may be hard to request a review from a person that does not have write access to the repository. Hope you find a solution :-) Yeah, I'm hoping they still show up in the suggestions for reviewers if they've recently modified the file, but I'm not sure that's possible with GitHub. I will keep looking. At least code written by NuttX committers is still a large percentage of the code base. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
