tinnedkarma commented on issue #17004: URL: https://github.com/apache/nuttx/issues/17004#issuecomment-3286755901
I am a bit late to this discussion, so maybe I'll take my input as a side note. * `CONFIG_BOARD_LOOPSPERMSEC` is in the "System Type" menu (arch/Kconfig file), also the only "board" config in the arch directory. The board configs should go to "Board Selection" menu (boards/Kconfig file). I see that there is a PR opened already, may be an idea for a change. * Maybe a different view will bring new ideas. The main reason that no value makes sense (no sane default) is because this value should come from "outside" nuttx's code base. It is a board configuration, if you do not know the board, you cannot know the expected value. My suggestion (although bit more drastic) is to drop the BOARD_LOOPSPERMSEC config (delete this entry from the Kconfig files), add an #error macro that explains that this value should be provided externally (by the board user/developer) and be defined in the board.h file (in my opinion, everything board related should be there and only there). As it stand right now, based on the pipeline output, the CONFIG_BOARD_LOOPSPERMSEC config should be set independently for each board anyway and by its nature it is fairly static (once the correct value is found, no reason to alter it), and fairly coupled to the board's clock configuration (that's why I suggest keeping this info in board.h). I see no reason to be a Kconfig config :). I also suggest keeping the name as is although it should not keep the CONFIG_ prefix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
