xiaoxiang781216 commented on issue #17004: URL: https://github.com/apache/nuttx/issues/17004#issuecomment-3289105993
> [@linguini1](https://github.com/linguini1) BTW, why set the magic value to -1 instead of simply removing the default value for `CONFIG_BOARD_LOOPSPERMSEC`? Both will cause a compilation error, but with no default value, if the user don't care about busy delays at all this option can be ignored. Normal practice when a kconfig option has no default value is to omit `default XX`, not to give magic values. > > EDIT: The last sentence here seems incorrect. Most (if not all) "int" kconfig options in NuttX have a default value assigned, so "-1" is probably better :) Yes, the default value is important for us, since we implement the busy loop by hardware timer which doesn't need calibration and magic number at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
