fdcavalcanti commented on code in PR #17021: URL: https://github.com/apache/nuttx/pull/17021#discussion_r2350309066
########## boards/risc-v/esp32c6/common/src/esp_board_oa_tc6.c: ########## @@ -0,0 +1,212 @@ +/**************************************************************************** + * boards/risc-v/esp32c6/common/src/esp_board_oa_tc6.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <stdint.h> +#include <stdio.h> +#include <assert.h> +#include <debug.h> +#include <stdbool.h> + +#include <nuttx/spi/spi.h> +#include <nuttx/irq.h> +#include <nuttx/net/oa_tc6.h> + +#include <arch/board/board.h> + +#include "espressif/esp_spi.h" +#include "espressif/esp_gpio.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define BOARD_OA_TC6_0_INT_PIN 5 + +/**************************************************************************** + * Private Function Prototypes + ****************************************************************************/ + +static int board_oa_tc6_attach(FAR const struct oa_tc6_config_s *config, + xcpt_t handler, + FAR void *arg); + +static int board_oa_tc6_enable(FAR const struct oa_tc6_config_s *config, + bool enable); + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static const struct oa_tc6_config_s g_esp_oa_tc6_config = +{ + .id = SPIDEV_ETHERNET(0), + .frequency = 25000000, + .chunk_payload_size = 64, + .rx_cut_through = true, + .attach = board_oa_tc6_attach, + .enable = board_oa_tc6_enable, +}; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: board_oa_tc6_attach + * + * Description: + * Configure interrupt and attach handler to the interrupt signal + * from the MAC-PHY. + * + * Input Parameters: + * config - reference to the MAC-PHY configuration + * handler - the interrupt handler function + * arg - reference passed to the handler on invocation + * + * Returned Value: + * On success OK is returned, otherwise ERROR is returned. + * + ****************************************************************************/ + +static int board_oa_tc6_attach(FAR const struct oa_tc6_config_s *config, + xcpt_t handler, FAR void *arg) +{ + int pin; + + switch (config->id) + { + case SPIDEV_ETHERNET(0): + pin = BOARD_OA_TC6_0_INT_PIN; + break; + default: + + /* Unknown id */ + + DEBUGPANIC(); + return ERROR; + } + + esp_configgpio(pin, INPUT_FUNCTION_2 | PULLUP); + irq_attach(ESP_PIN2IRQ(pin), handler, arg); + + return OK; +} + +/**************************************************************************** + * Name: board_oa_tc6_enable + * + * Description: + * Enable or disable the interrupt on the hardware level. + * Enable when the enable argument is true, otherwise disable. + * + * Input Parameters: + * config - reference to the MAC-PHY configuration + * enable - enable / disable control + * + * Returned Value: + * On success OK is returned, otherwise ERROR is returned. + * + ****************************************************************************/ + +static int board_oa_tc6_enable(FAR const struct oa_tc6_config_s *config, + bool enable) +{ + int pin; + + switch (config->id) + { + case SPIDEV_ETHERNET(0): + pin = BOARD_OA_TC6_0_INT_PIN; + break; + default: + + /* Unknown id */ + + DEBUGPANIC(); + return ERROR; + } + + if (enable) + { + esp_gpioirqenable(ESP_PIN2IRQ(pin), FALLING); + } + else + { + esp_gpioirqdisable(ESP_PIN2IRQ(pin)); + } + + return OK; +} + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: board_oa_tc6_initialize + * + * Description: + * Initialize and register the OA-TC6 10BASE-T1x network driver. + * + * Input Parameters: + * None + * + * Returned Value: + * Zero (OK) on success; a negated errno value on failure. + * + ****************************************************************************/ + +int board_oa_tc6_initialize(void) +{ + FAR struct spi_dev_s *spi; + int ret; + + spi = esp_spibus_initialize(ESPRESSIF_SPI2); + if (!spi) Review Comment: ```suggestion if (spi == NULL) ``` ########## boards/risc-v/esp32c6/common/src/esp_board_oa_tc6.c: ########## @@ -0,0 +1,212 @@ +/**************************************************************************** + * boards/risc-v/esp32c6/common/src/esp_board_oa_tc6.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <stdint.h> +#include <stdio.h> +#include <assert.h> +#include <debug.h> +#include <stdbool.h> + +#include <nuttx/spi/spi.h> +#include <nuttx/irq.h> +#include <nuttx/net/oa_tc6.h> + +#include <arch/board/board.h> + +#include "espressif/esp_spi.h" +#include "espressif/esp_gpio.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define BOARD_OA_TC6_0_INT_PIN 5 + +/**************************************************************************** + * Private Function Prototypes + ****************************************************************************/ + +static int board_oa_tc6_attach(FAR const struct oa_tc6_config_s *config, + xcpt_t handler, + FAR void *arg); + +static int board_oa_tc6_enable(FAR const struct oa_tc6_config_s *config, + bool enable); + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static const struct oa_tc6_config_s g_esp_oa_tc6_config = +{ + .id = SPIDEV_ETHERNET(0), + .frequency = 25000000, + .chunk_payload_size = 64, + .rx_cut_through = true, + .attach = board_oa_tc6_attach, + .enable = board_oa_tc6_enable, +}; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: board_oa_tc6_attach + * + * Description: + * Configure interrupt and attach handler to the interrupt signal + * from the MAC-PHY. + * + * Input Parameters: + * config - reference to the MAC-PHY configuration + * handler - the interrupt handler function + * arg - reference passed to the handler on invocation + * + * Returned Value: + * On success OK is returned, otherwise ERROR is returned. + * + ****************************************************************************/ + +static int board_oa_tc6_attach(FAR const struct oa_tc6_config_s *config, + xcpt_t handler, FAR void *arg) +{ + int pin; + + switch (config->id) + { + case SPIDEV_ETHERNET(0): + pin = BOARD_OA_TC6_0_INT_PIN; + break; + default: + + /* Unknown id */ + + DEBUGPANIC(); + return ERROR; + } + + esp_configgpio(pin, INPUT_FUNCTION_2 | PULLUP); + irq_attach(ESP_PIN2IRQ(pin), handler, arg); + + return OK; +} + +/**************************************************************************** + * Name: board_oa_tc6_enable + * + * Description: + * Enable or disable the interrupt on the hardware level. + * Enable when the enable argument is true, otherwise disable. + * + * Input Parameters: + * config - reference to the MAC-PHY configuration + * enable - enable / disable control + * + * Returned Value: + * On success OK is returned, otherwise ERROR is returned. + * + ****************************************************************************/ + +static int board_oa_tc6_enable(FAR const struct oa_tc6_config_s *config, + bool enable) +{ + int pin; + + switch (config->id) + { + case SPIDEV_ETHERNET(0): + pin = BOARD_OA_TC6_0_INT_PIN; + break; + default: + + /* Unknown id */ + + DEBUGPANIC(); + return ERROR; + } + + if (enable) + { + esp_gpioirqenable(ESP_PIN2IRQ(pin), FALLING); + } + else + { + esp_gpioirqdisable(ESP_PIN2IRQ(pin)); + } + + return OK; +} + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: board_oa_tc6_initialize + * + * Description: + * Initialize and register the OA-TC6 10BASE-T1x network driver. + * + * Input Parameters: + * None + * + * Returned Value: + * Zero (OK) on success; a negated errno value on failure. + * + ****************************************************************************/ + +int board_oa_tc6_initialize(void) +{ + FAR struct spi_dev_s *spi; + int ret; + + spi = esp_spibus_initialize(ESPRESSIF_SPI2); + if (!spi) + { + syslog(LOG_ERR, + "ERROR: Failed to initialize SPI port %d\n", ESPRESSIF_SPI2); + return -ENODEV; + } + + /* Bind the SPI port and config to the OA-TC6 driver */ + + ret = oa_tc6_initialize(spi, &g_esp_oa_tc6_config); + if (ret < 0) Review Comment: ```suggestion if (ret != OK) ``` Reason for this is that I noticed some return codes coming with ERROR but not negative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
