xiaoxiang781216 commented on code in PR #17071: URL: https://github.com/apache/nuttx/pull/17071#discussion_r2380678589
########## drivers/timers/CMakeLists.txt: ########## @@ -22,6 +22,13 @@ set(SRCS) +# Unless a driver with a more accurate version of up_*delay is enabled, always +# include the base delay definition (busy-loop) as a minimum-viable product. + +if(NOT CONFIG_TIMER_ARCH) Review Comment: before up_udelay is implemented by arch/driver, that's why the implementation in driver call the internal function to get the timestamp. With your implementation, up_udelay is part of sched, so it could call clock_systime_timespec to get more accuracy. The only problem is that we need check the context(early boot, interrupt) before calling clock_systime_timespec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
