linguini1 commented on PR #17075: URL: https://github.com/apache/nuttx/pull/17075#issuecomment-3356973373
> do you review the change in detail? this type of change doesn't generate any visible log difference. That doesn't matter. I'm not looking for log differences, I'm looking for logs to prove that the change was tested on hardware. Log changes aren't the regression here, breaking the scheduler is the regression. > This patch series doesn't change any schedule logic and behavior as @suoyuanG said in pr and commit message, I don't know what log do you want to provide? It doesn't matter what the author says about the schedule logic and behavior not changing. They have to _prove_ it. It might introduce a regression that we don't spot just by looking at the change. It's great that in theory it shouldn't break anything, but that is not always the case once it gets tested. I want the logs to prove that the change was tested on hardware, since you keep stating that it was. > Since I think the discussion in this pr already explain why we made this change clear and https://github.com/apache/nuttx/pull/17121 depends on this pr, that's why @GUIDINGLI merge it to unblock @wangchdo 's work. Okay. I don't agree with you, and myself and the other three reviewers made it clear. In the future, please provide a proper justification for dismissing my reviews ('fix' is not an appropriate justification). I personally don't think you should be dismissing any reviews until the people who have requested them agree or at least have discussed it. You decided for me, Alan, Alin and wangchdo that our review comments were not important. That is not proper review etiquette. > that's why @GUIDINGLI merge it to unblock @wangchdo 's work. wangchdo themselves asked for more testing first!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
