acassis commented on PR #17187:
URL: https://github.com/apache/nuttx/pull/17187#issuecomment-3397791009

   > Hi @acassis , you need to align CMake.
   > 
   > stm32_serial.c 
https://github.com/acassis/incubator-nuttx/blob/6b070c4c28e3f901ed2ee1470da642b0c1cb2d03/arch/arm/src/stm32/CMakeLists.txt#L38
   > 
   > ```
   > if(CONFIG_STM32_USART)
   >   list(APPEND SRCS stm32_serial.c)
   > endif()
   > ```
   
   Is there some way to include a warning in the CI when someone changed a 
Makefile in a directory where there is a CMake file? It could avoid missing it 
case you or other reviews miss it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to