xiaoxiang781216 commented on code in PR #17187:
URL: https://github.com/apache/nuttx/pull/17187#discussion_r2425168120
##########
arch/arm/src/common/arm_nputs.c:
##########
@@ -39,10 +39,12 @@
*
****************************************************************************/
+#ifndef CONFIG_ARM_SEMIHOSTING_SYSLOG
void up_nputs(const char *str, size_t len)
Review Comment:
could we add weak atrribute
##########
drivers/misc/lwl_console.c:
##########
@@ -294,6 +294,22 @@ static ssize_t lwlconsole_write(FAR struct file *filep,
* Public Functions
****************************************************************************/
+/****************************************************************************
+ * Name: up_putc
+ ****************************************************************************/
+
+void up_putc(int ch)
+{
+ /* If link not initialize just return */
+
+ if (!linkactive())
+ {
+ return;
+ }
+
+ write8bits(LWL_PORT_CONSOLE, (uint8_t) ch);
Review Comment:
```suggestion
write8bits(LWL_PORT_CONSOLE, (uint8_t)ch);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
