suoyuanG commented on code in PR #17190: URL: https://github.com/apache/nuttx/pull/17190#discussion_r2425341348
########## arch/arm/src/common/arm_internal.h: ########## @@ -479,6 +479,13 @@ size_t arm_stack_check(void *stackbase, size_t nbytes); void arm_stack_color(void *stackbase, size_t nbytes); #endif +#if defined(CONFIG_STACK_COLORATION) &&\ + defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3 +void arm_color_intstack(void); Review Comment: Yes, this ensures that the symbol exists at compile time. But in my opinion, this will not cause any misunderstandings to developers, because the condition I set here can be understood from the function name. The reason I do this is that I don't want to make this judgment separately in other places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
