tinnedkarma commented on code in PR #17190: URL: https://github.com/apache/nuttx/pull/17190#discussion_r2425325846
########## arch/arm/src/common/arm_internal.h: ########## @@ -479,6 +479,13 @@ size_t arm_stack_check(void *stackbase, size_t nbytes); void arm_stack_color(void *stackbase, size_t nbytes); #endif +#if defined(CONFIG_STACK_COLORATION) &&\ + defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3 +void arm_color_intstack(void); Review Comment: I see this pattern in many places throughout the code base. Does it have any functional benefits? In my experience it hides the defines that guards the function when called. It leaves the impression that the function is always called, when in fact there are cases that it's not a function at all, just a empty define. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
