xiaoxiang781216 commented on PR #17075: URL: https://github.com/apache/nuttx/pull/17075#issuecomment-3354699475
> @acassis @jerpelea and myself requested hardware test logs, and @wangchdo stated they think it would be worth running further tests. My review where I requested those changes specifically was dismissed. If you tested on hardware regularly, as you say, include the logs. It is a contribution requirement. Something needs to be done to prevent the ability here of just dismissing those requests for logs and merging anyways. do you review the change in detail? this type of change doesn't generate any visible log difference. > @xiaoxiang781216 you said that it was tested on real hardware, but it is important to list the test in the commit summary test. The author didn't provide it, even after three people here requested it. > > Modifications involving critical areas of the kernel can damage many platforms and bring unsuspected side effects > I find it disrespectful that this PR was merged despite three separate reviewers requesting additional logs from hardware tests. > This patch series doesn't change any schedule logic and behavior as @suoyuanG said in pr and commit message, I don't know what log do you want to provide? Since I think the discussion in this pr already explain why we made this change clear and https://github.com/apache/nuttx/pull/17121 depends on this pr, that's why @GUIDINGLI merge it to unblock @wangchdo 's work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
