tinnedkarma commented on code in PR #3192: URL: https://github.com/apache/nuttx-apps/pull/3192#discussion_r2448743197
########## system/init/init.h: ########## @@ -0,0 +1,93 @@ +/**************************************************************************** + * apps/system/init/init.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __APPS_SYSTEM_INIT_INIT_H +#define __APPS_SYSTEM_INIT_INIT_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <syslog.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define TIMESPEC2MS(t) (((t).tv_sec * 1000) + (t).tv_nsec / 1000000) + +#ifdef CONFIG_SYSTEM_INIT_DEBUG +#define init_debug(...) syslog(LOG_DEBUG, ##__VA_ARGS__) +#define init_dump_args(argc, argv) \ + { \ + int _i; \ + for (_i = 0; _i < (argc); _i++) \ + { \ + init_debug(" argv[%d] '%s'", _i, (argv)[_i]); \ + } \ + } +#else +#define init_debug(...) +#define init_dump_args(...) +#endif + +#ifdef CONFIG_SYSTEM_INIT_INFO +#define init_info(...) syslog(LOG_INFO, ##__VA_ARGS__) +#else +#define init_info(...) +#endif + +#ifdef CONFIG_SYSTEM_INIT_WARN +#define init_warn(...) syslog(LOG_WARNING, ##__VA_ARGS__) +#else +#define init_warn(...) +#endif + +#ifdef CONFIG_SYSTEM_INIT_ERR +#define init_err(f, ...) syslog(LOG_ERR, "Error " f, ##__VA_ARGS__) +#else +#define init_err(...) +#endif + +#define init_log(p, ...) \ Review Comment: > Common usage; it can avoid syntax issues such as those occurring after expansion: Yes but the same issues can be avoided by adding the curly braces. > As for runtime efficiency, the compiler will perform optimizations. No, the compiler will not optimize the code in any way, is will generate predicable assembly. Here is an example of code optimization [https://github.com/apache/nuttx/issues/17206](https://github.com/apache/nuttx/issues/17206). Personally I would avoid intentionally offloading work to the compiler. It's our job to write predictable code. > This requires listing all levels; moreover, some code inspection tools will consider that some cases are missing breaks. Yet, I still think it's a cleaner. :D We are not getting anywhere. That is my personal view, it's fine if we do not agree, and anyway more input is always welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
