PruteanuVlad opened a new pull request, #17241:
URL: https://github.com/apache/nuttx/pull/17241

   ## Summary
   
   Currently, the driver code for HW accelerated AES is not usable since it's 
not registered within esp32_crypto. This commit fixes it as well as a few bugs.
   
   **Modified files:**
   
   arch/xtensa/src/esp32/esp32_aes.c - remove 16 B key size limit and fix CTR 
mode case fall-through bug
   arch/xtensa/src/esp32/esp32_crypto.c - add missing link to esp32_aes.c driver
   boards/xtensa/esp32/esp32-devkitc/configs/crypto/defconfig - enabled AES
   
   ## Impact
   
   Impact on user: this PR completes the support for the hardware accelerated 
AES on ESP32, improving platform support
   Impact on build process: none
   Impact on hardware: this PR completes the support for the hardware 
accelerated AES on ESP32, improving platform support
   Impact on documentation: none, support for AES is already (kind of 
mistakenly) listed
   Impact on security: none, since 99% of the code was already there. This 
implementation has been appropriately tested, see testing section.
   Impact on compatibility: none
   
   ## Testing
   
   Development was done using ESP32 DevkitC.
   Building was done on Ubuntu 24.04 VM.
   For testing, I ran the official AES tests: 
   
https://github.com/apache/nuttx-apps/blob/master/testing/drivers/crypto/aesctr.c
   
https://github.com/apache/nuttx-apps/blob/master/testing/drivers/crypto/aescbc.c
   output shown below.
   nsh> aescbc
   aescbc test ok
   nsh> aesctr
   OK test vector 0
   OK test vector 1
   OK test vector 2
   OK test vector 3
   OK test vector 4
   OK test vector 5
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to