acassis commented on code in PR #17241:
URL: https://github.com/apache/nuttx/pull/17241#discussion_r2457334511


##########
arch/xtensa/src/esp32/esp32_aes.c:
##########
@@ -595,11 +595,6 @@ int aes_cypher(void *out, const void *in, size_t size,
       return -EINVAL;
     }
 
-  if (keysize != 16)
-    {
-      return -EINVAL;
-    }
-

Review Comment:
   Did you test using different keysize ? Maybe it should be important to 
include some safeguard like the maximum keysize allowed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to