simbit18 commented on PR #17197: URL: https://github.com/apache/nuttx/pull/17197#issuecomment-3442574638
@lupyuen , I don't remember, but it definitely concerns checking *.h and *.c files with the nxstyle tool. My thoughts on serialising Pros - It definitely forces contributors to correct the NuttX style for CMake .h and .c files first. Cons - If something gets stuck in the check step, we won't see if the build step is OK. However, it's a good idea, so it might be worth making this change, but first we also need to think about how to bypass the check step. On our mirror https://github.com/NuttX/nuttx, we need to modify the file enable-macos-windows.sh build.yml has been renamed to ci.yml You need to modify enable-macos-windows.sh file=.github/workflows/build.yml -> ci.yml tmp_file=$tmp_dir/build.yml -> ci.yml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
