hartmannathan commented on PR #1630:
URL: https://github.com/apache/nuttx-apps/pull/1630#issuecomment-3452197371

   > @Cynerd any plans to continue with this PR? Otherwise I think we should 
close it.
   
   @linguini1 @cederom @acassis @xiaoxiang781216 
   
   IMHO we should *never* silently download external packages!
   
   Why:
   
   1. Security reasons: some developers need to ensure only known bits are used 
in the build.
   
   2. Offline / airgapped build environments: some developers will need to 
manually obtain external packages.
   
   3. Customization: some developers will want to customize the external 
packages, use alternative versions or branches, or supply their own substitute.
   
   In fact I think in Kconfig we should have a global permission switch, 
similar to "allow GPL" / "allow BSD", called "Allow downloads" 
(CONFIG_ALLOW_DOWNLOADS). All invocations of curl, wget, git, or other remote 
download commands should be gated behind this switch to avoid the unwanted 
accidental download.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to