Cynerd commented on PR #1630:
URL: https://github.com/apache/nuttx-apps/pull/1630#issuecomment-3452708666

   The point of this was not to hide the info about the downloaded package. 
That is just not what this does. It instead replaces the download progress with 
a message that is part of the existing NuttX reporting functionality that was 
introduced in the NuttX build system. You are still informed that the download 
is happening, but standard NuttX build progress reporting is not broken by the 
download progress.
   
   Honestly, I would prefer that nothing be downloaded in the build phase, but 
that would require probably an additional phase to be added in NuttX itself (if 
that wasn't done in the meantime).
   
   I haven't invested any time in this the past year, so I would just close 
this. As I already once stated, it is treewide, and because every package 
manages downloads in its own separate way, it is a lot of work to do this 
switch. I should have probably only added defines and done the change step by 
step. In the meantime, I saw that NuttX now has `DOWNLOAD` defined, so 
hopefully packages will migrate on their own, and thus this PR introduces 
absolutely nothing new.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to