anchao commented on PR #17216: URL: https://github.com/apache/nuttx/pull/17216#issuecomment-3456289812
I am not denying nxinit, so I have not added any comments in the apps repository. All my comments here are about discussing how nxinit should be implemented, rather than rejecting the merging of this PR. I don't understand why there was such an intense reaction during the discussion, even to the extent of closing the PR. nxinit provides system service monitoring capabilities, which were missing from the previous startup scripts. However, I believe we need to be cautious if nxinit is to be integrated into the nuttx kernel, for the following 2 reasons: 1. nxinit will cause the system to support two sets of script syntax: android init and nuttx shell 2. If developers of nsh want to use the service daemon capability, they need to replace the initialization entry, and the code previously in the nuttx init script cannot be used continuously Whether to enhance the existing system implementation or create a new set of implementations, the choice is yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
