acassis commented on code in PR #17236:
URL: https://github.com/apache/nuttx/pull/17236#discussion_r2472687056
##########
arch/risc-v/src/common/espressif/Make.defs:
##########
@@ -233,6 +236,7 @@ ifeq ($(CONFIG_ESP_WIRELESS),y)
$(Q) echo "Applying patches..."
$(Q) cd chip/$(ESP_HAL_3RDPARTY_REPO)/components/mbedtls/mbedtls && git
apply ../../../nuttx/patches/components/mbedtls/mbedtls/*.patch
endif
+endif
Review Comment:
I think we should have a "else" here to instruct to user to download the
repository manually, otherwise it will fail silently and the end user will not
know what to do. @fdcavalcanti @hartmannathan @eren-terzioglu suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
