raiden00pl commented on code in PR #17236:
URL: https://github.com/apache/nuttx/pull/17236#discussion_r2472929248
##########
Kconfig:
##########
@@ -264,6 +264,14 @@ config APPS_DIR
example, to include makefile fragments (e.g., .config or
Make.defs)
or to set up include file paths.
+config ALLOW_DOWNLOADS
Review Comment:
> If we want to use depends on ARCH_CHIP_ESPRESSIF, we need to add config
ARCH_CHIP_ESPRESSIF again.
Idon't see a problem here. You can add `ARCH_CHIP_ESPRESSIF` again but now
in `arch/Kconfig` so it can be used by xtensa and risc-v chips
##########
Kconfig:
##########
@@ -264,6 +264,14 @@ config APPS_DIR
example, to include makefile fragments (e.g., .config or
Make.defs)
or to set up include file paths.
+config ALLOW_DOWNLOADS
Review Comment:
> If we want to use depends on ARCH_CHIP_ESPRESSIF, we need to add config
ARCH_CHIP_ESPRESSIF again.
I don't see a problem here. You can add `ARCH_CHIP_ESPRESSIF` again but now
in `arch/Kconfig` so it can be used by xtensa and risc-v chips
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
