Ouss4 commented on a change in pull request #1610:
URL: https://github.com/apache/incubator-nuttx/pull/1610#discussion_r473700716
##########
File path: arch/xtensa/src/esp32/esp32_spi.c
##########
@@ -695,13 +1005,72 @@ static uint32_t esp32_spi_send(FAR struct spi_dev_s
*dev, uint32_t wd)
}
/****************************************************************************
- * Name: esp32_spi_exchange
+ * Name: esp32_spi_send
Review comment:
```suggestion
* Name: esp32_spi_dma_send
```
##########
File path: arch/xtensa/src/esp32/esp32_spi.c
##########
@@ -158,6 +190,20 @@ static void esp32_spi_deinit(FAR struct spi_dev_s *dev);
* Public Function Prototypes
****************************************************************************/
+extern uint8_t esp32_spi2_status(FAR struct spi_dev_s *dev, uint32_t devid);
+extern uint8_t esp32_spi3_status(FAR struct spi_dev_s *dev, uint32_t devid);
+
+/* Use board level CS select function */
+
+#ifdef CONFIG_ESP32_SPI_UDCS
+extern void esp32_spi2_select(FAR struct spi_dev_s *dev,
+ uint32_t devid,
+ bool selected);
+extern void esp32_spi3_select(FAR struct spi_dev_s *dev,
+ uint32_t devid,
+ bool selected);
+#endif
+
Review comment:
These are already prototyped in the header file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
