Ouss4 commented on a change in pull request #1610:
URL: https://github.com/apache/incubator-nuttx/pull/1610#discussion_r473945259



##########
File path: arch/xtensa/src/esp32/Kconfig
##########
@@ -362,11 +362,53 @@ endmenu # I2C configuration
 menu "SPI configuration"
        depends on ESP32_SPI
 
+config ESP32_SPI_SWCS
+       bool "SPI software CS"
+       default y
+       ---help---
+               Use SPI software CS.
+
+config ESP32_SPI_UDCS
+       bool "User defined CS"
+       default n
+       depends on ESP32_SPI_SWCS
+       ---help---
+               Use user defined CS.
+
+choice
+       prompt "DMA owner"
+       default ESP32_SPI2_DMA
+       depends on ESP32_SPI2 || ESP32_SPI3
+       ---help---
+               Select which SPI owns DMA, only one SPI DMA is available, so
+               only one SPI can use DMA.

Review comment:
       Ah ok, you wanted to dedicate one DMA channel for SPI1.  I think we can 
still manage that through Kconfig and have the two channels available for SPI2 
and SPI3 in case SPI1 is not used, but I understand if this is how things are 
set now and can be improved for another iteration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to