Fix-Point commented on code in PR #17556:
URL: https://github.com/apache/nuttx/pull/17556#discussion_r2630244848
##########
sched/wdog/wd_cancel.c:
##########
@@ -61,32 +61,37 @@
int wd_cancel(FAR struct wdog_s *wdog)
{
irqstate_t flags;
- bool head;
+ int ret = -EINVAL;
+ bool head = false;
- flags = spin_lock_irqsave(&g_wdspinlock);
+ if (wdog != NULL)
+ {
+ sched_note_wdog(NOTE_WDOG_CANCEL, (FAR void *)wdog->func,
Review Comment:
Most of the changes prepared for hrtimer are general and can simplify kernel
implementation and reduce kernel latency even without the introduction of
hrtimer. I am going to split them into several parts.
I do not support the merging of https://github.com/apache/nuttx/pull/17517.
I believe the design of that HRTimer is completely flawed and lacks
corresponding performance and parallel correctness tests.
This HRTimer design is entirely different from
https://github.com/apache/nuttx/pull/17517, and there is no basis for the claim
that it is an improvement upon it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
