patacongo commented on a change in pull request #1613:
URL: https://github.com/apache/incubator-nuttx/pull/1613#discussion_r474235443
##########
File path: arch/xtensa/src/esp32/hardware/esp32_soc.h
##########
@@ -371,4 +372,162 @@
/* Other interrupt numbers should be managed by the user */
+#define DR_REG_APB_CTRL_BASE 0x3ff66000 /* Old name for
SYSCON, to be removed */
+#define APB_CTRL_SYSCLK_CONF_REG (DR_REG_APB_CTRL_BASE + 0x0)
+#define APB_CTRL_XTAL_TICK_CONF_REG (DR_REG_APB_CTRL_BASE + 0x4)
Review comment:
Please fix alignment.
##########
File path: arch/xtensa/src/esp32/hardware/esp32_soc.h
##########
@@ -371,4 +372,162 @@
/* Other interrupt numbers should be managed by the user */
+#define DR_REG_APB_CTRL_BASE 0x3ff66000 /* Old name for
SYSCON, to be removed */
+#define APB_CTRL_SYSCLK_CONF_REG (DR_REG_APB_CTRL_BASE + 0x0)
+#define APB_CTRL_XTAL_TICK_CONF_REG (DR_REG_APB_CTRL_BASE + 0x4)
+
+/* APB_CTRL_PRE_DIV_CNT : R/W ;bitpos:[9:0] ;default: 10'h0 ; */
+
+#define APB_CTRL_PRE_DIV_CNT 0x000003FF
+#define APB_CTRL_PRE_DIV_CNT_M
((APB_CTRL_PRE_DIV_CNT_V)<<(APB_CTRL_PRE_DIV_CNT_S))
+#define APB_CTRL_PRE_DIV_CNT_V 0x3FF
+#define APB_CTRL_PRE_DIV_CNT_S 0
+
+#define I2C_BBPLL_IR_CAL_DELAY 0
+#define I2C_BBPLL_IR_CAL_EXT_CAP 1
+#define I2C_BBPLL_OC_ENB_FCAL 4
+#define I2C_BBPLL_OC_ENB_VCON 10
+#define I2C_BBPLL_BBADC_CAL_7_0 12
+
+#define I2C_BBPLL_OC_LREF 2
+#define I2C_BBPLL_OC_LREF_MSB 7
+#define I2C_BBPLL_OC_LREF_LSB 7
+
+#define I2C_BBPLL_OC_DIV_7_0 3
+#define I2C_BBPLL_OC_DIV_7_0_MSB 7
+#define I2C_BBPLL_OC_DIV_7_0_LSB 0
+
+#define I2C_BBPLL_BBADC_DSMP 9
+#define I2C_BBPLL_BBADC_DSMP_MSB 7
+#define I2C_BBPLL_BBADC_DSMP_LSB 4
+
+#define I2C_BBPLL_OC_DCUR 5
+#define I2C_BBPLL_OC_DCUR_MSB 2
+#define I2C_BBPLL_OC_DCUR_LSB 0
+
+#define I2C_BBPLL_ENDIV5 11
+
+#define I2C_BBPLL 0x66
+#define I2C_BBPLL_HOSTID 4
+
Review comment:
Please fix alignment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
