cederom commented on code in PR #17554:
URL: https://github.com/apache/nuttx/pull/17554#discussion_r2659607534
##########
drivers/rpmsg/rpmsg.c:
##########
@@ -209,6 +209,18 @@ FAR const char *rpmsg_get_cpuname(FAR struct rpmsg_device
*rdev)
return rpmsg ? rpmsg->ops->get_cpuname(rpmsg) : NULL;
}
+int rpmsg_get_signals(FAR struct rpmsg_device *rdev)
+{
+ FAR struct rpmsg_s *rpmsg = rpmsg_get_by_rdev(rdev);
+
+ if (rpmsg->ops->get_signals)
Review Comment:
possible nutt pointer dereference here if *rpmsg and/or *rdev is null.
please add additional checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
