michallenc commented on code in PR #17694:
URL: https://github.com/apache/nuttx/pull/17694#discussion_r2660664668
##########
drivers/can/can.c:
##########
@@ -595,6 +595,25 @@ static int can_xmit(FAR struct can_dev_s *dev)
}
}
+#ifdef CONFIG_CAN_TXCANCEL
+ if (TX_PENDING(&dev->cd_sender) && can_txneed_cancel(&dev->cd_sender))
Review Comment:
As above, the given problem was considered with FIFO ordering, not priority
ordering on hardware level.
##########
drivers/can/can.c:
##########
@@ -595,6 +595,25 @@ static int can_xmit(FAR struct can_dev_s *dev)
}
}
+#ifdef CONFIG_CAN_TXCANCEL
+ if (TX_PENDING(&dev->cd_sender) && can_txneed_cancel(&dev->cd_sender))
+ {
+ if (can_cancel_mbmsg(dev))
Review Comment:
Yes, I was considering this in regards to HW FIFO ordering, not priority
ordering.
##########
drivers/can/Kconfig:
##########
@@ -134,6 +134,15 @@ config CAN_TXPRIORITY
---help---
Prioritize sending based on canid.
+config CAN_TXCANCEL
+ bool "Implement tx cancel ability"
+ default n
+ depends on CAN_TXPRIORITY
Review Comment:
Yes, my idea was that maybe this could be just one configuration option with
both functionalities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
