xiaoxiang781216 commented on code in PR #3265:
URL: https://github.com/apache/nuttx-apps/pull/3265#discussion_r2684706753
##########
system/cu/cu_main.c:
##########
@@ -474,7 +478,7 @@ int main(int argc, FAR char *argv[])
}
if (start_of_line == 1 && ch == cu->escape)
- {
+ {
Review Comment:
revert
##########
testing/ostest/ostest_main.c:
##########
@@ -511,6 +512,7 @@ static int user_main(int argc, char *argv[])
check_test_memory_usage();
#endif
+#ifdef CONFIG_ENABLE_ALL_SIGNALS
Review Comment:
```suggestion
#ifndef CONFIG_DISABLE_ALL_SIGNALS
```
##########
nshlib/nsh_proccmds.c:
##########
@@ -1393,6 +1398,7 @@ int cmd_top(FAR struct nsh_vtbl_s *vtbl, int argc, FAR
char **argv)
}
}
+#ifdef CONFIG_ENABLE_FULL_SIGNALS
Review Comment:
```suggestion
#ifdef CONFIG_ENABLE_ALL_SIGNALS
```
##########
nshlib/nsh_proccmds.c:
##########
@@ -1357,7 +1360,9 @@ int cmd_top(FAR struct nsh_vtbl_s *vtbl, int argc, FAR
char **argv)
FAR char *pidlist = NULL;
size_t num = SIZE_MAX;
size_t i;
+#ifdef CONFIG_ENABLE_FULL_SIGNALS
Review Comment:
```suggestion
#ifdef CONFIG_ENABLE_ALL_SIGNALS
```
##########
testing/ostest/ostest_main.c:
##########
Review Comment:
need guard by CONFIG_DISABLE_ALL_SIGNALS
##########
testing/ostest/ostest_main.c:
##########
@@ -534,18 +536,22 @@ static int user_main(int argc, char *argv[])
check_test_memory_usage();
#endif
+#endif /* CONFIG_DISABLE_ALL_SIGNALS */
+
#ifdef CONFIG_BUILD_FLAT
printf("\nuser_main: wdog test\n");
wdog_test();
check_test_memory_usage();
#endif
#ifndef CONFIG_DISABLE_POSIX_TIMERS
+#ifdef CONFIG_ENABLE_ALL_SIGNALS
Review Comment:
let's reorder the test case to reduce `#if/#else/#endif` check
##########
nshlib/nsh_proccmds.c:
##########
@@ -873,6 +873,7 @@ static int top_cmpcpuload(FAR const void *item1, FAR const
void *item2)
}
}
+#ifdef CONFIG_ENABLE_FULL_SIGNALS
Review Comment:
```suggestion
#ifdef CONFIG_ENABLE_ALL_SIGNALS
```
##########
testing/ostest/ostest_main.c:
##########
Review Comment:
need guard by CONFIG_ENABLE_ALL_SIGNALS
##########
testing/ostest/ostest_main.c:
##########
Review Comment:
need guard by CONFIG_ENABLE_ALL_SIGNALS
##########
system/cu/cu_main.c:
##########
@@ -484,27 +488,27 @@ int main(int argc, FAR char *argv[])
nwrite = i + 1;
- /* We've seen and escape (~) character, echo it to local
- * terminal and read the next char from serial
- */
+ /* We've seen and escape (~) character, echo it to local
Review Comment:
revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
