xiaoxiang781216 commented on code in PR #3265:
URL: https://github.com/apache/nuttx-apps/pull/3265#discussion_r2690827042
##########
netutils/dhcpc/dhcpc.c:
##########
@@ -533,8 +533,16 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int ret;
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
Review Comment:
```suggestion
#ifndef CONFIG_ENABLE_ALL_SIGNALS
```
##########
examples/timer/Kconfig:
##########
@@ -6,7 +6,7 @@
config EXAMPLES_TIMER
tristate "Timer example"
default n
- depends on TIMER
+ depends on TIMER && ENABLE_ALL_SIGNALS
Review Comment:
move to new pr, so this pr can pass the ci and merge first.
##########
system/cu/cu_main.c:
##########
@@ -489,22 +493,22 @@ int main(int argc, FAR char *argv[])
*/
write(STDOUT_FILENO, &ch, 1);
- start_of_line = 0;
- escaping = true;
- continue;
+ start_of_line = 0;
Review Comment:
revert the change from here to the end of this file
##########
netutils/dhcpc/dhcpc.c:
##########
@@ -533,8 +533,16 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int ret;
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
+ pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL);
+ pthread_setcanceltype(PTHREAD_CANCEL_DEFERRED, NULL);
+#endif
+
while (1)
{
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
Review Comment:
```suggestion
#ifndef CONFIG_ENABLE_ALL_SIGNALS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
