csanchezdll commented on issue #17914: URL: https://github.com/apache/nuttx/issues/17914#issuecomment-3756181649
> Question: what is the necessity to run CI on each merged PR? @linguini1 changeset A successfully building and changeset B successfully building (separately) does not necessarily imply changeset A+B (or B+A) builds successfully. A clear (there are many others) example is both A and B adding a global symbol with the same name on different files: both build separately, no common files changes so no conflicts, but applying both has a duplicate symbol error. I am not saying we can not remove the post-merge CI, I am saying we need to carefully consider and understand the trade-offs. Incompatible but non-conflicting PRs are, not very common, so that is in favor of your proposal. OTOH, when they happen, it means master has broken (both incompatible PRs are already merged), and in such situation an early detection allows quickly reverting the second PR, avoiding other PR on top of that also failing and consuming runner resources non-efficiently. As a personal opinion, I thing master branch stability is paramount and I would keep post-merge PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
