acassis commented on code in PR #17881:
URL: https://github.com/apache/nuttx/pull/17881#discussion_r2695701734
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
Review Comment:
```suggestion
bool "QEMU x86_64 chip"
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
Review Comment:
QEMU is always upper case, see: https://www.qemu.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
