acassis commented on code in PR #17881:
URL: https://github.com/apache/nuttx/pull/17881#discussion_r2695711485
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is QEMU.
+
+config ARCH_CHIP_INTEL64
+ bool "intel64 x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is Intel64.
Review Comment:
Please improve ---help--- Description
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is QEMU.
Review Comment:
Please improve the ---help--- Description. What people needs to know to
decide to enable or not this option?
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is QEMU.
+
+config ARCH_CHIP_INTEL64
+ bool "intel64 x86_64 chip"
Review Comment:
```suggestion
bool "Intel64 x86_64 chip"
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is QEMU.
+
+config ARCH_CHIP_INTEL64
+ bool "intel64 x86_64 chip"
Review Comment:
This is the original name that was in the other Kconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
