linguini1 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2701323457
########## sched/clock/delay.c: ########## Review Comment: Actually, I looked into this and there are a few files which re-define the delay functions to use hardware timers: - cxd56_delay.c - tc32_udelay.c - rv32m1_delay.c - intel64_tsc_ndelay.c So it's not possible to remove these custom implementations or remove the `weak_function`, otherwise we will need to avoid compiling `delay.c` when any of these architectures are in use. I think it's easier to keep the weak function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
