xiaoxiang781216 commented on code in PR #18011: URL: https://github.com/apache/nuttx/pull/18011#discussion_r2704000625
########## net/udp/udp_callback.c: ########## @@ -80,7 +80,8 @@ static uint16_t udp_datahandler(FAR struct net_driver_s *dev, conn_lock(&conn->sconn); #if CONFIG_NET_RECV_BUFSIZE > 0 - if (conn->readahead && conn->readahead->io_pktlen > conn->rcvbufs) + if (conn->readahead && conn->readahead->io_pktlen > conn->rcvbufs && + iob_navail(true) == 0) Review Comment: why add iob_navail check ########## net/icmp/icmp_input.c: ########## @@ -153,7 +153,7 @@ static uint16_t icmp_datahandler(FAR struct net_driver_s *dev, /* Copy the ICMP message into the I/O buffer chain (without waiting) */ ret = iob_clone_partial(dev->d_iob, dev->d_iob->io_pktlen, - 0, iob, 0, true, false); + 0, iob, 0, false, false); Review Comment: why change to false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
