zhhyu7 commented on code in PR #18011: URL: https://github.com/apache/nuttx/pull/18011#discussion_r2704210403
########## net/icmp/icmp_input.c: ########## @@ -153,7 +153,7 @@ static uint16_t icmp_datahandler(FAR struct net_driver_s *dev, /* Copy the ICMP message into the I/O buffer chain (without waiting) */ ret = iob_clone_partial(dev->d_iob, dev->d_iob->io_pktlen, - 0, iob, 0, true, false); + 0, iob, 0, false, false); Review Comment: > why change to false try not to restrict the packet of control types, the main reason is that the number of such messages is generally relatively small, and second, the business logic is often relatively simple, so the messages will be consumed immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
