jwang12340 commented on code in PR #18039:
URL: https://github.com/apache/nuttx/pull/18039#discussion_r2710853439
##########
drivers/can/ctucanfd_pci.c:
##########
@@ -641,12 +650,24 @@ static int ctucanfd_chrdev_send(FAR struct can_dev_s *dev,
{
fmt.s.ide = 1;
id.s.id_ext = msg->cm_hdr.ch_id;
+
+ /* Set txbuf record used for txconfirm */
+
+# ifdef CONFIG_CAN_TXCONFIRM
+ priv->tx_idbuf[txidx] = CAN_EFF_FLAG | msg->cm_hdr.ch_id;
+# endif
Review Comment:
> Confirmation does not work correctly with the test, because confirmation
messages are recognized as the responses from the other side of the ping-pong
test.
confirmation frame is marked with：
hdr.ch_dlc = 0;
hdr.ch_tcf = 1;
but for the frame received from other side, the hdr.ch_tcf flag will not be
set, can this mark be used as a basis for identification?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
