adamfeuer commented on a change in pull request #1647:
URL: https://github.com/apache/incubator-nuttx/pull/1647#discussion_r476790828
##########
File path: Documentation/Pipfile
##########
@@ -6,10 +6,9 @@ verify_ssl = true
[dev-packages]
[packages]
-recommonmark = "*"
-m2r2 = "==0.2.5"
-Sphinx = "==3.2.1"
-sphinx-rtd-theme = "==0.5.0"
Review comment:
@btashton @v01d The problem with using just a requirements.txt file is
that you have to manually update requirements, test, and pin them because
you're trying to use one file for both functions; and you have no tooling to
support you. In my experience this makes the project brittle. The requirements
don't get updated often and the project breaks eventually.
pipenv solves this by having a workflow that supports pinned requirements
for CI and regular users, while developers can update the Pipfile.lock easily
using pipenv's automatic pinning. I would prefer we keep them and do this
instead whenever requirements are updated:
pipenv run pip freeze > requirements.txt
That said, if both of you feel strongly that we should delete the
Pipfile/Pipfile.lock I'll go along with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
