v01d commented on a change in pull request #1647:
URL: https://github.com/apache/incubator-nuttx/pull/1647#discussion_r476803604
##########
File path: Documentation/Pipfile
##########
@@ -6,10 +6,9 @@ verify_ssl = true
[dev-packages]
[packages]
-recommonmark = "*"
-m2r2 = "==0.2.5"
-Sphinx = "==3.2.1"
-sphinx-rtd-theme = "==0.5.0"
Review comment:
My only expectation would be that both CI and people who clone the repo
and tries to build the docs will use the same version of these packages and
they will not be updated until someone decides to do so. If we stick to a
version that works, I don't see how that could break. There's also not much
reason to upgrade frequently.
Anyway, I do not feel strongly about either, I don't have python experience
to justify any preference. I don't like duplication in general and
requirements.txt seems easier to me to maintain (as I don't use pyenv either).
But I'll go with whatever you both feel is best.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
