v01d commented on a change in pull request #1646:
URL: https://github.com/apache/incubator-nuttx/pull/1646#discussion_r477250301
##########
File path: arch/arm/src/nrf52/hardware/nrf52_gpiote.h
##########
@@ -78,26 +63,30 @@
/* INTENSET/INTENCLR Register */
#define GPIOTE_INT_IN_SHIFT 0 /* Bits 0-7: Enable interrupt for event
IN[i] */
+
#define GPIOTE_INT_IN_MASK (0xff << GPIOTE_INT_IN_SHIFT)
# define GPIOTE_INT_IN(i) ((1 << (i + GPIOTE_INT_IN_SHIFT)) &
GPIOTE_INT_IN_MASK)
+
#define GPIOTE_INT_PORT 31 /* Bit 31: Enable interrupt for event
PORT */
/* CONFIG Register */
-#define GPIOTE_CONFIG_MODE_SHIFT 0 /* Bits 0-1: Mode */
-#define GPIOTE_CONFIG_MODE_MASK (0x3 << GPIOTE_CONFIG_MODE_SHIFT)
-# define GPIOTE_CONFIG_MODE_DIS (0x0 << GPIOTE_CONFIG_MODE_SHIFT) /* 0:
Disabled */
-# define GPIOTE_CONFIG_MODE_EV (0x1 << GPIOTE_CONFIG_MODE_SHIFT) /* 1: Event
*/
-# define GPIOTE_CONFIG_MODE_TS (0x3 << GPIOTE_CONFIG_MODE_SHIFT) /* 2: Task
*/
-#define GPIOTE_CONFIG_PSEL_SHIFT (8) /* Bits 8-12: GPIO number */
-#define GPIOTE_CONFIG_PSEL_MASK (0x1f << GPIOTE_CONFIG_PSEL_SHIFT)
-#define GPIOTE_CONFIG_PORT_SHIFT (13) /* Bit 13: GPIO port */
-#define GPIOTE_CONFIG_POL_SHIFT (16) /* Bits 16-17: Polarity */
-#define GPIOTE_CONFIG_POL_MASK (0x3 << GPIOTE_CONFIG_POL_SHIFT)
-# define GPIOTE_CONFIG_POL_NONE (0x0 << GPIOTE_CONFIG_POL_SHIFT) /* 0: None */
-# define GPIOTE_CONFIG_POL_LTH (0x1 << GPIOTE_CONFIG_POL_SHIFT) /* 1: LoToHi
*/
-# define GPIOTE_CONFIG_POL_HTL (0x2 << GPIOTE_CONFIG_POL_SHIFT) /* 2: HiToLo
*/
-# define GPIOTE_CONFIG_POL_TG (0x3 << GPIOTE_CONFIG_POL_SHIFT) /* 3: Toggle
*/
-#define GPIOTE_CONFIG_OUTINIT (20) /* Bit 20: Initial value */
+#define GPIOTE_CONFIG_MODE_SHIFT 0 /* Bits 0-1: Mode */
Review comment:
I re-aligned this block after renaming `GPIOTE_CONFIG_OUTINIT` to
`GPIOTE_CONFIG_OUTINIT_SHIFT` which was incorrectly named.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
