v01d commented on a change in pull request #1646:
URL: https://github.com/apache/incubator-nuttx/pull/1646#discussion_r477250549



##########
File path: arch/arm/src/nrf52/hardware/nrf52_radio.h
##########
@@ -436,11 +423,18 @@
 #define RADIO_MODE_MASK                   (0xf << RADIO_MODE_SHIFT)
 #define RADIO_MODE_NRF1MBIT               (0x00 << RADIO_MODE_SHIFT) /* 0: 1 
Mbit/s Nordic proprietary radio mode */
 #define RADIO_MODE_NRF2MBIT               (0x01 << RADIO_MODE_SHIFT) /* 1: 2 
Mbit/s Nordic proprietary radio mode */
+
+#if defined(CONFIG_ARCH_CHIP_NRF52832)
+#define RADIO_MODE_NRF250KBIT             (0x02 << RADIO_MODE_SHIFT) /* 2: 250 
kbit/s Nordic proprietary radio mode (deprecated) */
+#define RADIO_MODE_BLE1MBIT               (0x03 << RADIO_MODE_SHIFT) /* 3: 1 
Mbit/s BLE */
+#define RADIO_MODE_BLE2MBIT               (0x04 << RADIO_MODE_SHIFT) /* 4: 2 
Mbit/s BLE */
+#elif defined(CONFIG_ARCH_CHIP_NRF52840)
 #define RADIO_MODE_BLE1MBIT               (0x03 << RADIO_MODE_SHIFT) /* 3: 1 
Mbit/s BLE */
 #define RADIO_MODE_BLE2MBIT               (0x04 << RADIO_MODE_SHIFT) /* 4: 2 
Mbit/s BLE */
 #define RADIO_MODE_BLELR125KBIT           (0x05 << RADIO_MODE_SHIFT) /* 5: 
Long range 125 kbit/s TX, 125 kbit/s and 500 kbit/s RX */
 #define RADIO_MODE_BLELR500KBIT           (0x06 << RADIO_MODE_SHIFT) /* 6: 
Long range 500 kbit/s TX, 125 kbit/s and 500 kbit/s RX */
 #define RADIO_MODE_IEEE802154             (0x0f << RADIO_MODE_SHIFT) /* 15: 
IEEE 802.15.4-2006 250 kbit/s */
+#endif

Review comment:
       I missed that, I'll change it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to