Re: [PR] sched/hrtimer: fix hrtimer regression introduced by recent update and add support for tickless with hrtimer [nuttx]

Mon, 26 Jan 2026 22:03:01 -0800 


Fix-Point commented on code in PR #18174:
URL: https://github.com/apache/nuttx/pull/18174#discussion_r2730398492


##########
sched/hrtimer/hrtimer.h:
##########
@@ -122,26 +122,30 @@ void hrtimer_process(uint64_t now);
  *   ns - Expiration time in nanoseconds.
  *
  * Returned Value:
- *   OK (0) on success, negated errno on failure.
+ *   None.
+ *
+ * Assumptions:
+ *   The underlying timer start function returns 0 on success.
  ****************************************************************************/
 
 static inline_function void hrtimer_reprogram(uint64_t next_expired)
 {
-#ifdef CONFIG_SCHED_TICKLESS
-  int ret;
+  int ret = 0;
   struct timespec ts;
-#  ifdef CONFIG_SCHED_TICKLESS_ALARM
+
   clock_nsec2time(&ts, next_expired);
+
+#ifdef CONFIG_ALARM_ARCH
   ret = up_alarm_start(&ts);
-#  else
+#else
   struct timespec current;
   up_timer_gettime(&current);
   clock_nsec2time(&ts, next_expired);

Review Comment:
   Please remove this line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to