JianyuWang0623 commented on PR #18257: URL: https://github.com/apache/nuttx/pull/18257#issuecomment-3817674100
@xiaoxiang781216 @acassis @michallenc @raiden00pl For example, the type names in the C source code generated by protoc-c do not follow the snake case naming convention, but instead use a format such as `Perfetto__ReadBuffersResponse`. Additionally, protoc-c does not support custom configuration of naming styles. If NuttX application code needs to use these generated types, the format check will fail directly. Adding a whitelist is a viable approach, but it is more appropriate to include the generated source files in the whitelist as a whole. For the code that references these generated types/symbols, we only need to skip the format check for the parts related to the generated types/symbols, while the vast majority of the remaining code still needs to undergo a full format check. https://github.com/apache/nuttx/blob/master/tools/nxstyle.c#L692 For example - apps/system/perfetto/perfetto.c ``` /* nxstyle off */ typedef Perfetto__ReadBuffersResponse perfetto_response_t; ... ... /* nxstyle on */ ``` - auto-generated file - readbuffers.pb-c.c ``` struct Perfetto__ReadBuffersResponse { ... }; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
