xiaoxiang781216 commented on PR #18257: URL: https://github.com/apache/nuttx/pull/18257#issuecomment-3819117195
> > you can just asking the maintainer ignore the style error in the generated file. > > But that would cause CI to fail on that file. It's not a big problem for PR where generated file was introduced, but every subsequent PR that changes the file with non nxstyle code would fail as well and other maintainers and contributors would have to figure out if the code doesn't follow nxstyle on purpose or just accidentally. > The auto generated code shouldn't be edited manually, so the code is changed only when maintainer/contributor run protoc to regenerate the code again. The context is very clear for anybody. > It's much clearer to avoid this by allowing nxcheck tool to ignore parts of code or entire files and thus CI will still remain green. The only thing the maintainers would then be responsible is to judge if the code should be allowed to not follow nxstyle. the solution in this pr require you add the note into the generated code, which isn't good too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
