RB-tel commented on a change in pull request #1622:
URL: https://github.com/apache/incubator-nuttx/pull/1622#discussion_r478345636



##########
File path: arch/renesas/src/rx65n/rx65n_vector.S
##########
@@ -564,6 +548,21 @@ _uprx65_groupbl1_handler:
   multi_switching RX65N_GRPBL1_ADDR, RX65N_GENBL1_ADDR, 27, RX65N_ERI9_IRQ
 #endif /* CONFIG_RX65N_SCI9 */
 
+#ifdef CONFIG_RX65N_RIIC0
+  multi_switching RX65N_GRPBL1_ADDR, RX65N_GENBL1_ADDR, 13, 
RX65N_RIIC0_TEI0_IRQ

Review comment:
       Renesas RX65N supports Group Interrupts. Each Group Interrupt groups 
“unrelated” events from multiple peripherals. So segregating these events into 
respective peripheral drivers at the do_irq level complicates the 
implementation. And also in order to maintain trampoline style of 
implementation, ‘multi_switching’  assembly macro was implemented. With this 
implementation, single interrupt is expanded into multiple vector numbers and 
rest of the interrupt handling mechanism are maintained as is. Please let us 
know your comments. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to