pangzhen1xiaomi commented on code in PR #18072:
URL: https://github.com/apache/nuttx/pull/18072#discussion_r2769744867
##########
sched/Kconfig:
##########
@@ -1855,6 +1855,12 @@ config SCHED_HPWORKSTACKSIZE
---help---
The stack size allocated for the worker thread. Default: 2K.
+config SCHED_HPWORKSTACKSECTION
Review Comment:
> This is causing a failing build for RPi4B.
>
> Usage of this definition is guarded by
>
> ```c
> #ifdef SCHED_HPWORKSTACKSECTION
> ...
> ```
>
> In kwork_thread.c l561, but `ifdef` does not evaluate to false with the
default value `""` (empty string). There needs to be a boolean condition
guarding this.
>
> ```
> Create version.h
> LN: platform/board to /home/linguini/coding/nuttx-space/apps/platform/dummy
> Register: getprime
> Register: dd
> Register: ostest
> Register: nsh
> Register: sh
> Register: sdstress
> In file included from
/home/linguini/coding/nuttx-space/nuttx/include/sys/types.h:31,
> from
/home/linguini/coding/nuttx-space/nuttx/include/unistd.h:30,
> from wqueue/kwork_thread.c:29:
> wqueue/kwork_thread.c: In function 'work_start_highpri':
> wqueue/kwork_thread.c:564:15: error: 'CONFIG_SCHED_HPWORKSTACKSECTION'
undeclared (first use in this function); did you mean
'CONFIG_SCHED_HPWORKSTACKSIZE'?
> 564 | locate_data(CONFIG_SCHED_HPWORKSTACKSECTION);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> wqueue/kwork_thread.c:564:15: note: each undeclared identifier is reported
only once for each function it appears in
> wqueue/kwork_thread.c:564:3: error: section attribute argument not a
string constant
> 564 | locate_data(CONFIG_SCHED_HPWORKSTACKSECTION);
> | ^~~~~~~~~~~
> make[1]: *** [Makefile:65: kwork_thread.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [tools/LibTargets.mk:71: sched/libsched.a] Error 2
> make: *** Waiting for unfinished jobs....
> ```
Hi:
I think I've identified the root cause of the issue. It's a bug in the
makefile:
You might have SCHED_HPWORK disabled. Could you please try enabling
SCHED_HPWORK and test again? Alternatively, could you let me know which
configuration you used for compilation? I'll try to reproduce it locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
