pangzhen1xiaomi commented on code in PR #18072:
URL: https://github.com/apache/nuttx/pull/18072#discussion_r2771926033
##########
sched/wqueue/kwork_thread.c:
##########
@@ -578,9 +598,22 @@ int work_start_lowpri(void)
sinfo("Starting low-priority kernel worker thread(s)\n");
- return work_thread_create(LPWORKNAME, CONFIG_SCHED_LPWORKPRIORITY, NULL,
+#ifdef SCHED_LPWORKSTACKSECTION
+ static uint8_t lp_work_stack[CONFIG_SCHED_LPNTHREADS]
+ [CONFIG_SCHED_LPWORKSTACKSIZE]
+ locate_data(CONFIG_SCHED_LPWORKSTACKSECTION);
Review Comment:
> emm... stack align should set the data type to uint32_t or other arch
requirement ...
Thanks for the correction. I think it can be revised as follows:
static aligned_data(STACK_ALIGNMENT) uint8_t
lp_work_stack[CONFIG_SCHED_LPNTHREADS][CONFIG_SCHED_LPWORKSTACKSIZE]
locate_data(CONFIG_SCHED_LPWORKSTACKSECTION);
I'll submit another PR to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
