hartmannathan commented on code in PR #18366: URL: https://github.com/apache/nuttx/pull/18366#discussion_r2778566472
########## CONTRIBUTING.md: ########## @@ -349,6 +349,14 @@ Breaking these rules will be punished. See: https://github.com/apache/nuttx/blob/master/INVIOLABLES.md +### 1.18. Review etiquette. + +Reviewers should **NOT** flag a PR or a comment with the thumbs-down emoji. This +is considered offensive in some cultures. Review Comment: Perhaps we should explain that a thumbs down doesn't provide any information about why you disagree, and isn't enforced by the repository rules. ########## CONTRIBUTING.md: ########## @@ -349,6 +349,14 @@ Breaking these rules will be punished. See: https://github.com/apache/nuttx/blob/master/INVIOLABLES.md +### 1.18. Review etiquette. + +Reviewers should **NOT** flag a PR or a comment with the thumbs-down emoji. This +is considered offensive in some cultures. + +Instead, mark the PR with a request for changes and state precisely the changes +needed for the PR. Conversation surrounding code review should be constructive +and respectful. Review Comment: We could add that Request Changes is enforced by the repository rules, so if you request changes, please be sure to follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
